Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#846] Fix: issue in calling sub-DAG #848

Merged
merged 2 commits into from
Feb 18, 2025
Merged

[#846] Fix: issue in calling sub-DAG #848

merged 2 commits into from
Feb 18, 2025

Conversation

yottahmd
Copy link
Collaborator

@yottahmd yottahmd commented Feb 18, 2025 •
edited
Loading

Issue: #846

Changes:

  • Fixed the Request ID parameter flag name
  • Added integration test for calling sub-DAG

@yottahmd yottahmd self-assigned this Feb 18, 2025
@yottahmd yottahmd merged commit 6db86b9 into main Feb 18, 2025
4 checks passed
@yottahmd yottahmd deleted the 846-fix-issue branch February 18, 2025 14:51
@codecov Codecov
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 29.41176% with 12 lines in your changes missing coverage. Please review.

Project coverage is 55.47%. Comparing base (3618023) to head (e16e2dc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/digraph/executor/sub.go 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #848      +/-   ##
==========================================
- Coverage   55.53%   55.47%   -0.07%     
==========================================
  Files          75       75              
  Lines        8162     8171       +9     
==========================================
  Hits         4533     4533              
- Misses       3233     3242       +9     
  Partials      396      396
Files with missing lines Coverage Δ
cmd/config.go 73.91% <ø> (ø)
cmd/retry.go 55.26% <100.00%> (ø)
cmd/start.go 63.06% <100.00%> (ø)
internal/client/client.go 57.09% <100.00%> (ø)
internal/digraph/executor/sub.go 1.86% <0.00%> (-0.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3618023...e16e2dc. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yottahmd yottahmd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yottahmd